Multi-sources: Add agent data model and endpoint definition for multi sources #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api/v1alpha1/agent/openapi.yaml
Outdated
| @@ -53,6 +53,42 @@ paths: | |||
| application/json: | |||
| schema: | |||
| $ref: '../openapi.yaml#/components/schemas/Error' | |||
| /api/v1/agents/{id}: | |||
There was a problem hiding this comment.
Should this be /api/v1/agents/{id}/status?
There was a problem hiding this comment.
it can be. I wrote it like this cause we don't have another put operation on the agent.
I'll change it
tupyy
force-pushed
the
agent-api
branch
2 times, most recently
from
0045487 to
6cb6fb0
Compare
tupyy
force-pushed
the
agent-api
branch
2 times, most recently
from
a3479c4 to
c07847d
Compare
This commit adds the data model for agent resource. The source model has been modified by adding a many2one relationship to the agent. A new endpoint `/api/v1/agents` has been added but not implemented. Signed-off-by: Cosmin Tupangiu <[email protected]>
| type: object | ||
| properties: | ||
| id: | ||
| type: string |
There was a problem hiding this comment.
@nirarg Here we would like to have the version in the future.
| @@ -21,6 +21,7 @@ type Source struct { | |||
| SshKey string | |||
| Inventory *JSONField[api.Inventory] `gorm:"type:jsonb"` | |||
| CredUrl *string | |||
| Agents []Agent `gorm:"constraint:OnDelete:SET NULL;"` | |||
There was a problem hiding this comment.
What is now the relation between agents statuses and source status?
There was a problem hiding this comment.
good question. At this stage, the list of source statuses is the same with the agent's. Definitely, we should improve that.
| @@ -21,6 +21,7 @@ type Source struct { | |||
| SshKey string | |||
There was a problem hiding this comment.
We we want to move the sshkey out of here. Or will that be done in followup PRs?
machacekondra
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the data model and store implementation for agent resource. The source model has been modified by adding a many2one relationship to the agent.
A new endpoint
/api/v1/agentshas been defined but not implemented.There are no breaking changes in the current implementation.
Solves: ECOPROJECT-2271
Signed-off-by: Cosmin Tupangiu [email protected]